Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swell (Testnet) #690

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

atenjin
Copy link
Contributor

@atenjin atenjin commented Nov 18, 2024

Adding a New Chain

This PR adds Swell Testnet to the registry.

Checklist

  • I have declared the chain at the appropriate Superchain Level.
  • I have run just validate <chain-id> locally to ensure all local validation checks pass.
  • I have run just codegen to ensure that the chainlist and other generated files are up-to-date and include my chain.

@atenjin atenjin requested a review from a team as a code owner November 18, 2024 15:29
@Wazabie Wazabie self-assigned this Dec 3, 2024
@Wazabie Wazabie added F-do-not-merge Flag: Do Not Merge M-new-chain-request Meta: New Chain Request labels Dec 3, 2024
@Wazabie Wazabie removed the F-do-not-merge Flag: Do Not Merge label Dec 10, 2024
@sigma sigma added this pull request to the merge queue Dec 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 18, 2024
Copy link
Contributor

@sigma sigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this doesn't apply cleanly to main anymore

  • just codegen adds a "governed_by_optimism" flag
  • just validate 1924 throws some errors:
=== RUN   TestValidation/Swellchain_Testnet_(1924)/Data_Availability_Type
    data-availability-type_test.go:56:
                Error Trace:   .../github.com/ethereum-optimism/superchain-registry/validation/data-availability-type_test.go:56
                                                        .../github.com/ethereum-optimism/superchain-registry/validation/validation_test.go:44
                Error:          Received unexpected error:
                                operation failed permanently after 3 attempts: failed to retrieve previous nonce: missing trie node 486e81dbaf0d082af8a24573c8588c9db1fe72046a2a50fc5938baf82a3a18d0 (path ) state 0x486e81dbaf0d082af8a24573c8588c9db1fe72046a2a50fc5938baf82a3a18d0 is not available
                Test:           TestValidation/Swellchain_Testnet_(1924)/Data_Availability_Type
                Messages:       failed when checking chain for recent batcher txs from 0x77C60EfDBDa83410EE0373Eda2ed06891238c93d
--- FAIL: TestValidation/Swellchain_Testnet_(1924)/Data_Availability_Type (3.97s)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M-new-chain-request Meta: New Chain Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants